FT2320X patches, next round

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

FT2320X patches, next round

Uwe Bonnes
Hello,

the errors I saw were mostly related to the user program not reading the
eeprom in some situations and so flagging a wrong checksum. I also sharped
some rules for eeprom decoding, so some nonsense output for the FT2320x is
removed.

Bye
--
Uwe Bonnes                [hidden email]

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

ft230x_patches.tar.gz (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: FT2320X patches, next round

Thomas Jarosch
Hi Uwe,

> the errors I saw were mostly related to the user program not reading the
> eeprom in some situations and so flagging a wrong checksum. I also sharped
> some rules for eeprom decoding, so some nonsense output for the FT2320x is
> removed.

thanks, I'll check your patches and the other on3s from the mailinglist
hopefully next week. The flu got me the better of me right now...

Till then,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: FT2320X patches, next round

Thomas Jarosch
In reply to this post by Uwe Bonnes
Hi Uwe,

On Friday, 25. April 2014 10:50:37 Uwe Bonnes wrote:
> the errors I saw were mostly related to the user program not reading the
> eeprom in some situations and so flagging a wrong checksum. I also sharped
> some rules for eeprom decoding, so some nonsense output for the FT2320x
> is removed.

I've reviewed and applied your patches. Thanks!

The ftdi_write_data() constness patch was already included in September
2013, so I've skipped that.


Though I'm not sure about the ftdi_eeprom_build() change:
Do we really need to call ftdi_read_eeprom_location() in there?
It's something the user might not expect from a xxx_build() function.

Cheers,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: FT2320X patches, next round

Uwe Bonnes
>>>>> "Thomas" == Thomas Jarosch <[hidden email]> writes:

    Thomas> I've reviewed and applied your patches. Thanks!

Thanks for the review.

    Thomas> The ftdi_write_data() constness patch was already included in
    Thomas> September 2013, so I've skipped that.


    Thomas> Though I'm not sure about the ftdi_eeprom_build() change: Do we
    Thomas> really need to call ftdi_read_eeprom_location() in there?  It's
    Thomas> something the user might not expect from a xxx_build() function.

You mean reading the bytes  between 0x40 and 0x50? These bytes need to be
known for the checksum calculation.
--
Uwe Bonnes                [hidden email]

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Loading...