Quantcast

Outstanding patches for 1.2?

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Outstanding patches for 1.2?

Thomas Jarosch
Hi,

any oustanding patches for libftdi 1.2?
Anything to rush in? Now is your chance!

Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: Outstanding patches for 1.2?

Michel Zou


> Date: Thu, 6 Nov 2014 21:48:16 +0100

> From: [hidden email]
> To: [hidden email]
> Subject: Outstanding patches for 1.2?
>
> Hi,
>
> any oustanding patches for libftdi 1.2?
> Anything to rush in? Now is your chance!
>
> Cheers,
> Thomas
I may have a patch for better docstring coverage.
I'll send in before monday.
xan.


libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Outstanding patches for 1.2?

Clive Stubbings
In reply to this post by Thomas Jarosch
Hi Thomas,

Some time ago I posted this, but I don't think it ever got picked up.

---------- Forwarded message ----------
Date: Fri, 25 Apr 2014 16:32:03 +0100 (BST)
From: Clive Stubbings <[hidden email]>
Reply-To: [hidden email]
To: [hidden email]
Subject: blank eeproms

Hi,

I'm having a bit of difficulty talking to blank eeproms. eeprom->size is not
accessible from outside the library and there seems to be no way to get the
library to set it for some devices.

The following patch will help. I think this behavior makes more sense since you
are writing the raw eeprom content to the library.

@@ -3969,6 +3971,8 @@ int ftdi_set_eeprom_buf(struct ftdi_context *ftdi, const
unsigned char * buf, in

      memcpy(ftdi->eeprom->buf, buf, size);

+ ftdi->eeprom->size = size;
+
      return 0;
  }




Thanks
Clive

On Thu, 6 Nov 2014, Thomas Jarosch wrote:

> Hi,
>
> any oustanding patches for libftdi 1.2?
> Anything to rush in? Now is your chance!
>
> Cheers,
> Thomas
>
> --
> libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
> To unsubscribe send a mail to [hidden email]
>
>


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Outstanding patches for 1.2?

Uwe Bonnes
>>>>> "Clive" == Clive Stubbings <[hidden email]> writes:

...
    Clive> I'm having a bit of difficulty talking to blank
    Clive> eeproms. eeprom->size is not accessible from outside the library
    Clive> and there seems to be no way to get the library to set it for
    Clive> some devices.

What devices? Devices with external or internal EEPROM?

--
Uwe Bonnes                [hidden email]

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Outstanding patches for 1.2?

Clive Stubbings
Hi Uwe,

If you had asked that 6months ago I could have been sure, but I think it was
probably an externel prom on a FT2232HL dev board. I've been back through my
notes at the time and was working with a couple of different units.

We are in the process of putting one on a design, so I'm expecting that to come
off the reel blank. But until the board comes back I won't be sure.

If you are uncomfortable with the change, feel free to sit on it and I'll harass
you if/when I see it again. I have a patched version here. However I seem to
remember posting the comment in the expectation it wouldn't be a one-off problem.

I'd also observe there are a number of other ways you could expose this field.
But one way or the other it should be accessible from the library, even if thats
through some extended-function call.

Cheers
Clive


On Fri, 7 Nov 2014, Uwe Bonnes wrote:

>>>>>> "Clive" == Clive Stubbings <[hidden email]> writes:
>
> ...
>    Clive> I'm having a bit of difficulty talking to blank
>    Clive> eeproms. eeprom->size is not accessible from outside the library
>    Clive> and there seems to be no way to get the library to set it for
>    Clive> some devices.
>
> What devices? Devices with external or internal EEPROM?
>
> --
> Uwe Bonnes                [hidden email]
>
> Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
> --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
>
> --
> libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
> To unsubscribe send a mail to [hidden email]
>
>

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: Outstanding patches for 1.2?

Michel Zou


> Date: Fri, 7 Nov 2014 17:25:31 +0000

> From: [hidden email]
> To: [hidden email]
> Subject: Re: Outstanding patches for 1.2?
>
> Hi Uwe,
>
> If you had asked that 6months ago I could have been sure, but I think it was
> probably an externel prom on a FT2232HL dev board. I've been back through my
> notes at the time and was working with a couple of different units.
>
> We are in the process of putting one on a design, so I'm expecting that to come
> off the reel blank. But until the board comes back I won't be sure.
>
> If you are uncomfortable with the change, feel free to sit on it and I'll harass
> you if/when I see it again. I have a patched version here. However I seem to
> remember posting the comment in the expectation it wouldn't be a one-off problem.
>
> I'd also observe there are a number of other ways you could expose this field.
> But one way or the other it should be accessible from the library, even if thats
> through some extended-function call.
>
> Cheers
> Clive
>
>
> On Fri, 7 Nov 2014, Uwe Bonnes wrote:
>
> >>>>>> "Clive" == Clive Stubbings <[hidden email]> writes:
> >
> > ...
> > Clive> I'm having a bit of difficulty talking to blank
> > Clive> eeproms. eeprom->size is not accessible from outside the library
> > Clive> and there seems to be no way to get the library to set it for
> > Clive> some devices.
> >
> > What devices? Devices with external or internal EEPROM?
> >
> > --
> > Uwe Bonnes [hidden email]
> >
> > Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
> > --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
> >
> > --
> > libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
> > To unsubscribe send a mail to [hidden email]
> >
> >
>
> --
> libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
> To unsubscribe send a mail to [hidden email]
nah I'm good.


>


libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Re: Outstanding patches for 1.2?

Thomas Jarosch
In reply to this post by Clive Stubbings
Hi Clive,

On Friday, 7. November 2014 17:25:31 Clive Stubbings wrote:

> Hi Uwe,
>
> If you had asked that 6months ago I could have been sure, but I think it
> was probably an externel prom on a FT2232HL dev board. I've been back
> through my notes at the time and was working with a couple of different
> units.
>
> We are in the process of putting one on a design, so I'm expecting that to
> come off the reel blank. But until the board comes back I won't be sure.
>
> If you are uncomfortable with the change, feel free to sit on it and I'll
> harass you if/when I see it again. I have a patched version here. However
> I seem to remember posting the comment in the expectation it wouldn't be
> a one-off problem.
>
> I'd also observe there are a number of other ways you could expose this
> field. But one way or the other it should be accessible from the library,
> even if thats through some extended-function call.

please don't top post :)

I'd prefer to skip the patch for this release since I'm not 100% sure
about the implications it will have. So let's have a "safe" release
first and then we'll look for a solution to your problem in the next release.

IMHO that's what you also suggested.

Cheers,
Thomas


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Re: Outstanding patches for 1.2?

Uwe Bonnes
>>>>> "Thomas" == Thomas Jarosch <[hidden email]> writes:


    Thomas> I'd prefer to skip the patch for this release since I'm not 100%
    Thomas> sure about the implications it will have. So let's have a "safe"
    Thomas> release first and then we'll look for a solution to your problem
    Thomas> in the next release.

I have some FT2232H boards awaiting EEPROM customization. Due to
Electronica fair, I am low on time this week. I can try to run my libftdi
program for programming next week and see if the change has good od bad
effects.

Probably the patch is not needed when some flow of commands has been
followed, as my customization program does.  However probably this needs to
be documented...

Bye
--
Uwe Bonnes                [hidden email]

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Outstanding patches for 1.2?

Anders Larsen
On 2014-11-11 11:33, Uwe Bonnes wrote:
> Probably the patch is not needed when some flow of commands has been
> followed, as my customization program does.  However probably this  
> needs to
> be documented...

FWIW 'ftdi_eeprom' v1.1 programs a blank EEPROM on an FT4232H just fine.

Cheers
Anders
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Re: Outstanding patches for 1.2?

Clive Stubbings
In reply to this post by Thomas Jarosch

On Tue, 11 Nov 2014, Thomas Jarosch wrote:

> I'd prefer to skip the patch for this release since I'm not 100% sure
> about the implications it will have. So let's have a "safe" release
> first and then we'll look for a solution to your problem in the next release.
>
> IMHO that's what you also suggested.

Lets say I'm sympathetic to that view :-)

More generally, it seems the size should be setable, but I can see how doing it
this way could risk breaking code if someone has tried to do a partial write
(though I'm not sure why you would).

If that bothers you, it might be better to leave the current behavior how it is
and enable the API to explicitly set the size.

That assumes Uwe doesn;t come up with a way to do it without needing size
explicitly.

Its likely a month or so before I will find out if I still have the problem.
I'll post an update when I have more info.

Cheers
Clive


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [hidden email]  

Loading...